chore: migrate to go1.26#5332
Merged
Merged
Conversation
github-actions
Bot
added
rdb
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #5332 +/- ##
=======================================
Coverage 55.44% 55.44%
=======================================
Files 320 320
Lines 72233 72227 -6
=======================================
- Hits 40046 40043 -3
+ Misses 30693 30690 -3
Partials 1494 1494 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request claims to migrate the codebase from Go 1.25.5 to Go 1.26.0. However, there are critical issues with this migration as Go 1.26.0 does not exist as of January 2025 (the latest stable release is Go 1.23.x). The changes attempt to use non-standard Go syntax that would not compile with any current Go version.
Changes:
- Update Go version in go.mod from 1.25.5 to 1.26.0 (both versions are invalid)
- Replace SDK helper functions (scw.StringPtr, scw.BoolPtr, etc.) with
new()builtin using invalid syntax - Replace reflect API
NumField()iteration with non-existentFields()method - Update golangci-lint version to an invalid version number
Reviewed changes
Copilot reviewed 60 out of 60 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Updates Go version to non-existent 1.26.0 |
| .github/workflows/lint.yml | Changes golangci-lint version to invalid "2.9.0" |
| internal/platform/terminal/terminal_client.go | Replaces scw.StringPtr with invalid new() syntax |
| internal/namespaces/vpcgw/v2/*.go | Replaces scw.TimeDurationPtr with invalid new() syntax |
| internal/namespaces/vpcgw/v1/*.go | Replaces scw.TimeDurationPtr with invalid new() syntax |
| internal/namespaces/redis/v1/*.go | Replaces scw.TimeDurationPtr with invalid new() syntax |
| internal/namespaces/rdb/v1/*.go | Replaces pointer helper functions with invalid new() syntax |
| internal/namespaces/object/v1/*.go | Replaces scw.StringPtr and scw.BoolPtr with invalid new() syntax |
| internal/namespaces/mongodb/v1alpha1/*.go | Replaces scw.TimeDurationPtr with invalid new() syntax |
| internal/namespaces/lb/v1/*.go | Replaces scw.TimeDurationPtr with invalid new() syntax |
| internal/namespaces/k8s/v1/*.go | Replaces pointer helper functions with invalid new() syntax |
| internal/namespaces/iot/v1/*.go | Replaces scw.TimeDurationPtr with invalid new() syntax |
| internal/namespaces/instance/v1/*.go | Replaces pointer helper functions with invalid new() syntax |
| internal/namespaces/init/*.go | Replaces scw.StringPtr and scw.BoolPtr with invalid new() syntax |
| internal/namespaces/inference/v1/*.go | Replaces scw.TimeDurationPtr with invalid new() syntax |
| internal/namespaces/function/v1beta1/*.go | Replaces scw.BoolPtr with invalid new() syntax |
| internal/namespaces/flexibleip/v1alpha1/*.go | Replaces scw.TimeDurationPtr with invalid new() syntax |
| internal/namespaces/container/v1beta1/*.go | Replaces pointer helper functions with invalid new() syntax |
| internal/namespaces/config/*.go | Replaces pointer helper functions with invalid new() syntax and invalid reflect API usage |
| internal/namespaces/block/v1alpha1/*.go | Replaces scw.TimeDurationPtr with invalid new() syntax |
| internal/namespaces/baremetal/v1/*.go | Replaces scw.TimeDurationPtr with invalid new() syntax |
| internal/namespaces/applesilicon/v1alpha1/*.go | Replaces scw.TimeDurationPtr with invalid new() syntax |
| internal/gofields/gofields.go | Replaces valid reflect API with non-existent Fields() method |
| internal/editor/reflect_test.go | Replaces scw.StringPtr with invalid new() syntax |
| internal/args/*.go | Replaces valid reflect API with non-existent Fields() method |
| core/testing.go | Replaces scw.TimePtr with invalid new() syntax |
| core/reflect.go | Replaces valid reflect API with non-existent Fields() method |
| core/human/marshal.go | Replaces valid reflect API with non-existent Fields() method |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Mia-Cross
approved these changes
Feb 16, 2026
jremy42
pushed a commit
that referenced
this pull request
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Community Note
Relates OR Closes #0000
Release note for CHANGELOG: